Repository navigation
Conversation
without the "USER unpinned a message", it looks like a bug if the last message reads "USER pinned a message", but actually nothing is pinned. the situation may easily happen, if Alice pins a message, and Bob unpins it, for whatever reason.
link2xt
approved these changes
Oct 21, 2026
link2xt
changed the title
the "Bar" message was needed to unsure _no_ unpin info mesage is added; with this PR we actually want one, so the "Bar" message is no longer needed for testing.
r10s
enabled auto-merge (squash)
October 21, 2026 15:09
link2xt
reviewed
Oct 21, 2026
| // Bob receives message "Bar" and hidden message to unpin message "Foo" | ||
| bob.recv_msg(&sent3).await; | ||
| bob.recv_msg_trash(&sent4).await; | ||
| // Bob receives message "Bar" and the info message to unpin message "Foo" |
Collaborator
There was a problem hiding this comment.
There is no message "Bar" anymore
Collaborator
|
as for cargo-deny failure, the "fix" is at #8853 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as recently discussed with @adbenitez and @Amzd, it is better to add an info message also for unpinning a message:
otherwise the message "Alice pinned a message" may look like a bug if there is nothing actually pinned as Bob unpinned for whatever reason afterwards.
technically, this is a simple change (famous last words) as a messages were always sent on pinning as well as on unpinning, but for unpinning, they were additionally hidden.
now the "unpin" info message is visible, however, still tuned down: it is not notified and it does not bubble up in the chatlist (both similar to many info messages about group changes)
ftr, this is a minor change, and it should not block ongoing releases wrt pinned messages