api!: remove all oauth support and drop DC_LP_AUTH* flags#8431
Conversation
r10s
left a comment
r10s
left a comment
There was a problem hiding this comment.
lgtm, thanks for the huge cleanup!
i am pretty confident, that this removal will not affect many ppl, maybe even no one. even when we removed gmail, very few ppl were really affected, for yandex probably even less, also as it is not possible to created new yandex accounts with oauth2 since 2+ years (you can created yandex profiles with apppasswords tho, that continues to be supported)
|
actually, CFFI was still referencing did a PR to remove that completely at deltachat/deltachat-android#4552 as there is nothing more to do, we can still merge this PR at any time, i'd say :) |
BREAKING CHANGE: removed oauth2 module, dc_get_oauth2_url FFI function, DC_LP_AUTH flags and configured/serverflags, and the oauth2 parameter/field from SMTP/IMAP clients, JSON-RPC interfaces, and CLI tools. also contains regenerated provider data after dropping oauth in the update script.
|
|
||
| # also add provider with no special things to do - | ||
| # eg. _not_ supporting oauth2 is also an information and we can skip the mx-lookup in this case | ||
| # eg. we can skip the mx-lookup in this case |
There was a problem hiding this comment.
MX records are not resolved since 2.23 (214a1d3) already.
The whole comment can be removed, it's not unexpected that if a provider is in the database then we add it.
There was a problem hiding this comment.
i am also removing the whole provider db support in #8437
the api is not used in java since 2+ years, and will be finally removed in core at chatmail/core#8431
3 participants
BREAKING CHANGE: removed oauth2 module, dc_get_oauth2_url FFI function, all DC_LP_AUTH flags, and the oauth2 parameter/field from SMTP/IMAP clients, JSON-RPC interfaces, and CLI tools.
also contains regenerated provider data after dropping oauth in the update script.
motivation: it's only yandex that is supported with OAUTH on android, but nobody knows if it works or of any users. We certainly don't want to maintain this code, and given we are currently engaging in automatic relay replacement handling, i think it's good to remove stale code/simplify things where we can.