fix: receive_imf: Look up key contact by intended recipient fingerprint (#7661) #7786
+135
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
commented
Jan 28, 2026
iequidoo
changed the title
…eferences messages in ad-hoc group This is an important thing forgotten to be checked in 3325270. Also there's another test which currently doesn't work as we want: outgoing encrypted messages continue to arrive to ad-hoc group even if we already have contact's key. This should be fixed by sending and receiving Intended Recipient Fingerprint subpackets. The good thing is that apparently there are no scenarios requiring the contact to update their software, the user should just update own devices.
It's strange that this wasn't covered by any test.
…contacts_fallback_to_chat() It only looks up contacts by address in the given chat, so `_fallback_to_chat` suffix is more informative. It's obvious that such a lookup is done by address, there are no other reasonable options.
…nt (#7661) For now, do this only for `OneOneChat` and `MailingListOrBroadcast`, this is enough to correctly support messages from modern Delta Chat versions sending Intended Recipient Fingerprint subpackets and single-recipient messages from modern versions of other MUAs.
iequidoo
force-pushed
the
iequidoo/intended-recipient-fps
branch
from
ff3406a to
52a8a4d
Compare
iequidoo
commented
Jan 29, 2026
| .await | ||
| } | ||
|
|
||
| /// Returns a new elena's "device". |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| /// Returns a new elena's "device". | |
| /// Returns new elena's "device". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, do this only for
OneOneChatandMailingListOrBroadcast, this is enough to correctlysupport messages from modern Delta Chat versions sending Intended Recipient Fingerprint subpackets
and single-recipient messages from modern versions of other MUAs.
Close #7661
test: Message in blocked chat arrives as InSeen-- unrelated, but just a one-line test improvement.