doc: Adapt the comment on MessageObject.showPadlock
#6925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
iOS is already adapted in a PR, deltachat/deltachat-ios#2746 , issue i noticed that "device chat" messages get the "letter" icon now as well. options:
i am in favour of 2., which also makes some sense as the message never left the device. iirc, we do similar for "saved messages" - in case of a single device they do not leave the device and are not encryted technically |
r10s
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to remove the padlock-icon from messages, and instead show an icon if the message was unencrypted: deltachat/deltachat-ios#2746
Now, it's confusing for implementers that there is a field
showPadlockin the jsonrpc. This PR adapts the comment.Two alternatives to this PR would be:
showPadlock, and introduce a fieldwasEncryptedshowPadlock, and introduce a fieldshowLetterIcon, which is the inverse ofshowPadlock.