api!: make logging macros private #6918
Merged
+253
−258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/log-module-private
branch
2 times, most recently
from
6a2ed76 to
523d6d3
Compare
link2xt
force-pushed
the
link2xt/log-module-private
branch
from
523d6d3 to
d3c7b3a
Compare
link2xt
changed the base branch from
main
to
link2xt/message-object-no-webxdc-info
link2xt
force-pushed
the
link2xt/log-module-private
branch
2 times, most recently
from
ba60e54 to
7b16ea9
Compare
link2xt
changed the title
log module private
link2xt
force-pushed
the
link2xt/log-module-private
branch
4 times, most recently
from
7b992d7 to
451029d
Compare
link2xt
changed the base branch from
link2xt/message-object-no-webxdc-info
to
main
link2xt
force-pushed
the
link2xt/log-module-private
branch
2 times, most recently
from
8224920 to
f81fe2a
Compare
link2xt
force-pushed
the
link2xt/log-module-private
branch
from
f81fe2a to
c3468f0
Compare
link2xt
force-pushed
the
link2xt/log-module-private
branch
from
c3468f0 to
c85e7b2
Compare
iequidoo
approved these changes
Jun 20, 2025
| @@ -120,7 +120,7 @@ async fn poke_spec(context: &Context, spec: Option<&str>) -> bool { | |||
| } else { | |||
| let rs = context.sql().get_raw_config("import_spec").await.unwrap(); | |||
| if rs.is_none() { | |||
| error!(context, "Import: No file or folder given."); | |||
| eprintln!("Import: No file or folder given."); | |||
There was a problem hiding this comment.
It's strange that in other places println! is used for logging, i.e. logs go to stdout. Should be fixed in a separate PR
src/smtp.rs
Outdated
Comment on lines
16
to
17
| use crate::log::warn; | ||
| use crate::log::{error, info}; |
There was a problem hiding this comment.
Suggested change
| use crate::log::warn; | |
| use crate::log::{error, info}; | |
| use crate::log::{error, info, warn}; |
link2xt
force-pushed
the
link2xt/log-module-private
branch
from
c85e7b2 to
68e412f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for #6919. I want to add dependency on the
tracingcrate into logging macros, but then they cannot be used by crates that do not importtracingas well. Overall not exporting internal logging macros seems cleaner to me, it also discourages library users from logging their own logs into our event channel.