Skip to content

fix: realtime late join #6869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix: realtime late join #6869

wants to merge 12 commits into from

Conversation

Septias
Copy link
Collaborator

@Septias Septias commented May 21, 2025

This PR adds a test to reproduce a bug raised by @adbenitez that peer channels break when the resend feature is used.

@WofWca
Copy link
Collaborator

WofWca commented May 22, 2025

This is still WIP? This only adds tests.

@Septias Septias marked this pull request as draft May 23, 2025 07:57
@Septias
Copy link
Collaborator Author

Septias commented Jul 7, 2025

Found out that somehow the wrong iroh topic is transmitted to fiona and that is why she fails to join. In every send invocation a new topic is generated, and we use resend...

@Septias Septias force-pushed the sk/test_webxdc_resend branch 2 times, most recently from fa9afd2 to ed12f9a Compare July 8, 2025 08:24
@Septias
Copy link
Collaborator Author

Septias commented Jul 8, 2025

@link2xt I made some unrelated changes, which are easy to track in the individual commits, but they pollute the final PR. Would you prefer to split this into a refactor and bug-fix PR?

@Septias Septias marked this pull request as ready for review July 8, 2025 12:39
@link2xt
Copy link
Collaborator

link2xt commented Jul 9, 2025

I made some unrelated changes, which are easy to track in the individual commits, but they pollute the final PR. Would you prefer to split this into a refactor and bug-fix PR?

If it's just these documentation updates then no need to split this.

@Septias Septias force-pushed the sk/test_webxdc_resend branch from 1c471ed to 2d12aec Compare July 10, 2025 07:58
@Septias
Copy link
Collaborator Author

Septias commented Jul 10, 2025

It seems like the test is a bit flaky (for me it ran 7/8 times), but I do not know a fix of the top of my head yet.. Maybe we can just check how often it actually happens and fix it if neccessary in a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants