-
-
Notifications
You must be signed in to change notification settings - Fork 104
fix: realtime late join #6869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: realtime late join #6869
Conversation
This is still WIP? This only adds tests. |
Found out that somehow the wrong iroh topic is transmitted to fiona and that is why she fails to join. In every send invocation a new topic is generated, and we use resend... |
fa9afd2
to
ed12f9a
Compare
@link2xt I made some unrelated changes, which are easy to track in the individual commits, but they pollute the final PR. Would you prefer to split this into a refactor and bug-fix PR? |
If it's just these documentation updates then no need to split this. |
1c471ed
to
2d12aec
Compare
It seems like the test is a bit flaky (for me it ran 7/8 times), but I do not know a fix of the top of my head yet.. Maybe we can just check how often it actually happens and fix it if neccessary in a follow up PR |
This PR adds a test to reproduce a bug raised by @adbenitez that peer channels break when the resend feature is used.