improve jsonrpc js docs #6168
Closed
improve jsonrpc js docs #6168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng more useful displayed on npm and on https://js.jsonrpc.delta.chat
Simon-Laux
commented
Nov 2, 2024
Member
Author
There was a problem hiding this comment.
this will be shown as start page for https://js.jsonrpc.delta.chat
Member
Author
|
needs rebase |
Hocuri
reviewed
Jan 12, 2026
| } | ||
|
|
||
| /// Returns a vector of contact IDs for given chat ID where the contact is not SELF. | ||
| pub async fn get_other_chat_contacts(context: &Context, chat_id: ChatId) -> Result<Vec<ContactId>> { |
Collaborator
There was a problem hiding this comment.
Looks like this landed in the PR accidentally?
Member
Author
There was a problem hiding this comment.
It is not the only thing that doesn't belong into it. I have to check everything again, and maybe it's easiest to copy wanted changes over to a fresh pr instead of dealing with git and rebasing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeltaChattoWebsocketDeltaChatEventandContextEventstype to include them in the documentation.@deltachat/jsonrpc-client. so there is something more useful displayed on npm and on https://js.jsonrpc.delta.chat