Skip to content

chore: update deltachat-jsonrpc JS dependencies #4989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Nov 13, 2023

No description provided.

@Simon-Laux
Copy link
Contributor

Simon-Laux commented Nov 15, 2023

I get these typescript errors when running npm run build locally:

> @deltachat/jsonrpc-client@1.131.0 build:tsc
> tsc

node_modules/@types/node/globals.d.ts:72:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

72 declare var AbortSignal: {
               ~~~~~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:2335:13
    2335 declare var AbortSignal: {
                     ~~~~~~~~~~~
    'AbortSignal' was also declared here.

node_modules/@types/ws/index.d.ts:321:18 - error TS2315: Type 'Server' is not generic.

321         server?: HTTPServer<V> | HTTPSServer<V> | undefined;
                     ~~~~~~~~~~~~~

node_modules/@types/ws/index.d.ts:321:34 - error TS2315: Type 'Server' is not generic.

321         server?: HTTPServer<V> | HTTPSServer<V> | undefined;
                                     ~~~~~~~~~~~~~~


Found 3 errors in 2 files.

Errors  Files
     1  node_modules/@types/node/globals.d.ts:72
     2  node_modules/@types/ws/index.d.ts:321
ERROR: "build:tsc" exited with 2.

maybe we should not update typescript? or depend on a specific version of @types/node?

@link2xt
Copy link
Collaborator Author

link2xt commented Nov 16, 2023

@Simon-Laux

Did you run npm i before running npm run build? For me npm run build executes fine.

maybe we should not update typescript?

Why?

or depend on a specific version of @types/node?

Which version, what is the problem with the version @types/ws depends on? For me it is in the output npm ls -a:

├─┬ @types/ws@8.5.9
│ └─┬ @types/node@20.9.0
│   └── undici-types@5.26.5

@link2xt link2xt added the node Nodejs bindings label Jan 6, 2024
@link2xt link2xt force-pushed the main branch 2 times, most recently from 1abb12e to 2af9ff1 Compare March 4, 2024 21:10
@link2xt link2xt force-pushed the link2xt/update-jsonrpc-js-deps branch from ae9a445 to 63d8534 Compare May 29, 2025 11:51
@link2xt link2xt force-pushed the link2xt/update-jsonrpc-js-deps branch from 63d8534 to e1a8ece Compare May 29, 2025 11:57
Copy link
Contributor

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine now, desktop uses the same ts version. But note that I haven't tested this.

@link2xt link2xt merged commit fd3e48d into main May 29, 2025
29 checks passed
@link2xt link2xt deleted the link2xt/update-jsonrpc-js-deps branch May 29, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Nodejs bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants