add group images

[r10s]

this pr adds a fallback group image if no group image is set, making groups and one-to-one-chats easier to distinguish, maybe mitigating confusions as of #4902 .

this is also what whatsapp is doing.

also it looks nicer imo :)

 

disadvantage is that different groups look more similar, however, this is probably a minor as one can easily set group images (whereas you cannot set images for other ppl and this is also not planned)

a minor technical issue is that you can no longer differ between "image not set" and "fallback image" - i checked recent UI, however, that also seems not to be needed currently - and if required, we can always add that.

resurrection a part of #2708

[hpk42]

i'd be fine with trying this.

[Simon-Laux]

what about people using emojis for their group avatars?:

this is also what whatsapp is doing.

WhatsApp also does it for contacts, so not exactly what WhatsApp is doing.

[r10s]

WhatsApp also does it for contacts, so not exactly what WhatsApp is doing.

well, what whatsapp is doing for group images then :)

for emoji-avatars: this is a hack anyways, coming a bit from times where we did not had avatars. the emoji is still visible in the title - and ppl can always use an image.

the gist of this issue, to better distinguish between groups and one-to-ones, while not cluttering UI with additional states and elements, i think this rules some emoji-hacks

[r10s]

i do not know, if emoji-avatars are really a thing, i would be for closing and not merging. all in all +0.1 :) but i do not really care - i closed the old pr for reasons of not having incredible discussions :)

[Simon-Laux]

I would rather do this icon thing in the UI instead of the letter.
Also I would prefer if the emoji trick would continue to work.

we could implement a detection algorithm in nom based on the emoji unicode ranges that can be found in the regex we use in desktop:

https://github.com/deltachat/deltachat-desktop/blob/559b5d87b9679924ecd2762b0fc841b675d9e154/src/renderer/components/conversations/emoji.ts#L61-L62

[link2xt]

in nom

Why would you need nom to detect if the first letter is emoji?

regex crate can match \p{Emoji} unicode class. This is still tricky because of EMOJI_MODIFIER etc. tables which are in regex-syntax crate.

Tests don't pass, need new API

[link2xt]

This still needs an API to tell if the avatar can be deleted or not.

[Raiden-GH]

What if users could choose whether to use an image, a letter, or an emoji, like in macOS? As long as the programming effort isn't too much.