Skip to content

add send_draft() to JSON-RPC API #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2023
Merged

add send_draft() to JSON-RPC API #4839

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d1623e
add send_draft()
adbenitez Oct 20, 2023
fc6f276
rename to misc_*
adbenitez Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions deltachat-jsonrpc/src/api/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2053,6 +2053,23 @@ impl CommandApi {

ChatId::new(chat_id).set_draft(&ctx, Some(&mut draft)).await
}

// send the chat's current set draft
async fn misc_send_draft(&self, account_id: u32, chat_id: u32) -> Result<u32> {
let ctx = self.get_context(account_id).await?;
if let Some(draft) = ChatId::new(chat_id).get_draft(&ctx).await? {
let mut draft = draft;
let msg_id = chat::send_msg(&ctx, ChatId::new(chat_id), &mut draft)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does sending the draft make it disappear from draft? or it most be manually removed after sending?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it keeps the msg_id, how can it be kept? Should be transformed into the same message.

Anyway, this PR needs a test checking that msg_id is kept and that no new message is created as a result.

.await?
.to_u32();
Ok(msg_id)
} else {
Err(anyhow!(
"chat with id {} doesn't have draft message",
chat_id
))
}
}
}

// Helper functions (to prevent code duplication)
Expand Down