Skip to content

feat: ensure subtype is supported for the remaining tag scopes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat: ensure subtype is supported for the remaining tag scopes #5

merged 2 commits into from
Dec 10, 2024

Conversation

RobChatloop
Copy link
Contributor

No description provided.

@RobChatloop
feat: ensure subtype is supported on the other tag scopes
86059b8
@RobChatloop
chore: make attachTag support single tag being provided
3f9caf3 
This was previously failing silently - appearing to attach with no apparent failure, but not actually attaching
@RobChatloop RobChatloop requested a review from haddowg December 10, 2024 13:36
@RobChatloop RobChatloop self-assigned this Dec 10, 2024
@RobChatloop RobChatloop changed the title Feat/scope subtype feat: ensure subtype is supported for the remaining tag scopes Dec 10, 2024
haddowg
haddowg approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@haddowg haddowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but the attach and detach methods should probably also accept optional subtype and pass to the findOrCreate and convertToTags calls

@haddowg haddowg merged commit c279c44 into main Dec 10, 2024
4 checks passed
@haddowg haddowg deleted the feat/scope-subtype branch December 10, 2024 15:09
@release-please release-please bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haddowg haddowg haddowg approved these changes

Assignees

@RobChatloop RobChatloop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobChatloop @haddowg