[M273] - Fix switching between documents (#98)

Author: danielkweon

VERSION

@@ -1 +1 @@
-v0.1.7
+v0.1.8

libreoffice-core/desktop/source/lib/wasm_extensions.cxx

@@ -296,8 +296,18 @@ WasmDocumentExtension::loadFromExpanded(LibreOfficeKit* pThis,
     // throughout the load process.
     comphelper::OStorageHelper::SetIsExpandedStorage(true);
     comphelper::OStorageHelper::SetExpandedStorage(xStorage);
-    comphelper::OStorageHelper::SetExpandedStorageBase(storageBase);
+
+
+    /*
+        storage instance MUST be set before storage base
+        instance and base are the same objects, just casted differently
+        instance is stored in an uno::Reference while base is stored in a shared_ptr
+        
+        if the base is released first (as the shared_ptr is set), the uno reference
+        has a bad time when it tries to access a null object at with it's pointer
+    */
     comphelper::OStorageHelper::SetExpandedStorageInstance(storage);
+    comphelper::OStorageHelper::SetExpandedStorageBase(storageBase);
 
     utl::MediaDescriptor aMediaDescriptor;
 

qa-env/src/OfficeDocument/OfficeDocument.tsx

@@ -154,7 +154,12 @@ export function OfficeDocument(props: Props) {
     };
     props.doc.on(CallbackType.DOCUMENT_SIZE_CHANGED, callback);
     onCleanup(() => {
-      props.doc.off(CallbackType.DOCUMENT_SIZE_CHANGED, callback);
+      // m273 this needs to be fixed, but this only occurs in this repo
+      try {
+        props.doc.off(CallbackType.DOCUMENT_SIZE_CHANGED, callback);
+      } catch (e) {
+        console.log('error', e);
+      }
     });
   });