This repository was archived by the owner on Feb 18, 2025. It is now read-only.
[M273] - Fix switching between documents #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synoet
reviewed
Oct 23, 2024
Comment on lines
+157
to
+161
| try { | ||
| props.doc.off(CallbackType.DOCUMENT_SIZE_CHANGED, callback); | ||
| } catch (e) { | ||
| console.log('error', e); | ||
| } |
There was a problem hiding this comment.
This needs to be actually fixed. My try/catch was just so I could test that it works.
There was a problem hiding this comment.
This prop doesn't exist and isn't how the app-monorepo with the blocks handles new documents. I'll add a note that this needs to be fixed, but I'm going to focus on fixing the app-monorepo first.
synoet
approved these changes
Oct 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/macro-eng/issue/M-273/switching-between-documents-using-expanded-doc-load-causes-a-crash
Issue and solution
storage instance MUST be set before storage base
instance and base are the same objects, just casted differently
instance is stored in an uno::Reference while base is stored in a shared_ptr
if the base is released first (as the shared_ptr is set), the uno reference has a bad time when it tries to access the instance (which is now a null object) with it's pointer
also bumping to version 0.1.8 to create a new build into app-monorepo