Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to actions #3

Merged
merged 6 commits into from
Nov 22, 2020
Merged

Switch to actions #3

merged 6 commits into from
Nov 22, 2020

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Nov 19, 2020

Switch to similar publish workflow with Chart.js

@simonbrunel
Copy link
Member

I don't understand this workflow, can you explain? What's the difference with the Travis one, which looks much simpler?

@kurkle
Copy link
Member Author

kurkle commented Nov 19, 2020

Difference is, this is triggered by publishing a release in github, not from the tag. And this sets the tag version to package.json before publishing.

.github/workflows/npmpublish.yml Outdated Show resolved Hide resolved
.github/workflows/npmpublish.yml Outdated Show resolved Hide resolved
.github/workflows/npmpublish.yml Outdated Show resolved Hide resolved
@etimberg etimberg merged commit bec61f8 into chartjs:master Nov 22, 2020
@kurkle kurkle deleted the actions branch December 4, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants