Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using es6 syntax for Chart.js 3.x #1

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Allow using es6 syntax for Chart.js 3.x #1

merged 1 commit into from
Oct 30, 2019

Conversation

benmccann
Copy link
Contributor

No description provided.

@benmccann benmccann mentioned this pull request Oct 30, 2019
Merged
@kurkle
Copy link
Member

kurkle commented Oct 30, 2019

Should this be a Major version?

@benmccann
Copy link
Contributor Author

I believe it shouldn't get pulled into projects automatically since it's pre-1.0, but I'd be fine making it a major version if that's preferred

@kurkle
Copy link
Member

kurkle commented Oct 30, 2019

Right, I was just worrying about auto updates.

@etimberg etimberg merged commit 41822f6 into chartjs:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @kurkle @etimberg