Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable canvas acceleration in Firefox 110 in test cases #737

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2023

@ghost
Copy link
Author

ghost commented Mar 15, 2023

@kurkle Would you maybe have time to review this? :)

@ghost
Copy link
Author

ghost commented Mar 16, 2023

Is the failed test a Windows issue or just a flaky test? My local run works just fine:

Chrome 111.0.0.0 (Mac OS 10.15.7): Executed 76 of 76 SUCCESS (2.728 secs / 2.759 secs)
Firefox 111.0 (Mac OS 10.15): Executed 76 of 76 SUCCESS (3.033 secs / 2.994 secs)
TOTAL: 152 SUCCESS

TOTAL: 152 SUCCESS

@stockiNail
Copy link
Contributor

@SebastiaanSafeguard the issue is a timeout. It happens on GITHUB cloud for Windows.

Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) in node_modules/jasmine-core/lib/jasmine-core/jasmine.js (line 8059)

A collaborator or maintainer should re-execute the test on Windows.

@ghost
Copy link
Author

ghost commented Mar 16, 2023

The result is the timeout, that's not the issue itself. There is always a reason for a timeout to happen.

@kurkle
Copy link
Member

kurkle commented Mar 16, 2023

The result is the timeout, that's not the issue itself. There is always a reason for a timeout to happen.

Windows workers time out randomly but consistently :)

@kurkle kurkle merged commit f6f178a into chartjs:master Mar 16, 2023
@ghost ghost deleted the disable-ff-canvas-accel branch March 17, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants