Fix initial call to isZoomedOrPanned #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isZoomedOrPanned incorrectly returns true if it's called before any zoom or pan operations are done. I believe that the `!== undefined` check should be valid; storeOriginalScaleLimits always sets the min/max value to chart.scales[scaleId]'s min/max, which TypeScript says are always defined. However, I could be missing something. Fixes chartjs#629
kurkle
approved these changes
Mar 10, 2022
|
I see that the build failed due to excessive cognitive complexity. Do you want me to fix this? I noticed that CodeClimate's cognitive complexity limit of 5 seems stricter than the configured ESLint cyclomatic complexity limit of 10. I don't see obvious unnecessary complexity, but I'm happy to break apart the function to reduce the complexity score if that's what's desired. |
|
No, I don't think that needs to be changed (approved it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isZoomedOrPanned incorrectly returns true if it's called before any zoom or pan operations are done.
I believe that the
!== undefinedcheck should be valid; storeOriginalScaleLimits always sets the min/max value to chart.scales[scaleId]'s min/max, which TypeScript says are always defined. However, I could be missing something.Fixes #629