Skip to content

Types: Update LayotPosition #8555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Types: Update LayotPosition #8555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/layout.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ChartArea } from './geometric';

export type LayoutPosition = 'left' | 'top' | 'right' | 'bottom' | 'chartArea';
export type LayoutPosition = 'left' | 'top' | 'right' | 'bottom' | 'center' | 'chartArea' | {[scaleId: string]: number};

export interface LayoutItem {
/**
Expand Down
11 changes: 11 additions & 0 deletions types/tests/layout/position.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { LayoutPosition } from '../../index.esm';

export const left: LayoutPosition = 'left';
export const right: LayoutPosition = 'right';
export const top: LayoutPosition = 'top';
export const bottom: LayoutPosition = 'bottom';
export const center: LayoutPosition = 'center';
export const axis: LayoutPosition = { x: 10 };

// @ts-expect-error invalid position
export const invalid: LayoutPosition = 'none';