Tooltip: add dataPoint and rename value to formattedValue #7618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Jul 14, 2020
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
This looks a lot better to me, should make things easier for many use cases.
etimberg
previously approved these changes
Jul 14, 2020
benmccann
force-pushed
the
tooltip-datapoint
branch
from
53d0ffb to
b37f516
Compare
kurkle
approved these changes
Jul 14, 2020
etimberg
approved these changes
Jul 14, 2020
etimberg
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Tooltip: add dataPoint and rename value to formattedValue * Add a test
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7563
This is an alternative to #7615
I renamed
valuetoformattedValueto make clear that it's a formatted string and differentiate from the newdataPoint. This was able to simplify a lot of the samples