Allow specifying spanGaps as number (max distance) #6993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Jan 21, 2020
Contributor
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
I don't really love the idea of making the line controller even more complicated, but at this point I'll probably just create the fastline chart instead of worrying about simplifying this one any more
| y, | ||
| skip: isNaN(x) || isNaN(y) | ||
| skip: isNaN(x) || isNaN(y), | ||
| stop: i > 0 && (parsed.x - prevParsed.x) > maxGapLength |
Contributor
There was a problem hiding this comment.
Maybe we could add skip and stop to properties only if true. I'm wondering if it would improve performance to make the object smaller
Member
Author
There was a problem hiding this comment.
benmccann
approved these changes
Jan 21, 2020
etimberg
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6457
Demo