Merged
Conversation
benmccann
force-pushed
the
scriptable-tick-fonts
branch
from
70ac152 to
1808cd1
Compare
Member
|
It would be more efficient to use one callback for font. But thats a bit bigger change. |
etimberg
reviewed
Jan 10, 2020
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Makes sense to me. Just want to confirm that there's no major performance hit. I think it's OK now because we filter the ticks before measuring in most cases
Contributor
Author
|
There's no perf hit because there are so few labels - this is run only after |
etimberg
previously approved these changes
Jan 10, 2020
benmccann
force-pushed
the
scriptable-tick-fonts
branch
from
1808cd1 to
74738ad
Compare
etimberg
approved these changes
Jan 12, 2020
Contributor
Author
|
@kurkle would you be able to give this a look? thanks! |
kurkle
approved these changes
Jan 13, 2020
kurkle
added a commit
to kurkle/Chart.js
that referenced
this pull request
Jan 21, 2020
This reverts commit 738ee34.
kurkle
added a commit
to kurkle/Chart.js
that referenced
this pull request
Jan 27, 2020
This reverts commit 738ee34.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2442