Skip to content

Conversation

@kurkle
Copy link
Member

@kurkle kurkle commented Nov 13, 2019

Closes: #1692 (see for details)

@kurkle kurkle added this to the Version 3.0 milestone Nov 13, 2019
@benmccann
Copy link
Contributor

The very first issue I ever opened in the Chart.js repo was that I didn't understand the difference between ticks, gridlines, and options. Thanks to @etimberg for the great answer there and sorry I never got around to opening a PR for the docs, but you did get me on the path to submitting many others! :-)

In #1692 the issue submitter is talking about ticks and labels as if they were the same thing and I think we could better differentiate as @etimberg commented (#1692 (comment)) on that thread.

Anyway, I agree that this way is better. I do wonder though if it's worth the migration headache since it will affect so many end users and I'm not sure the benefit is that large in this case. I don't feel strongly either way, so am okay in either case

@etimberg
Copy link
Member

Perhaps we could offer a migration tool? Paste your config, get the new config? Could do it all in JS

@kurkle
Copy link
Member Author

kurkle commented Nov 14, 2019

How about a migrating wrapper too (could use same code)?

Edit: I was thinking about users trying out v3. It would be simple with a config migrating wrapper instead of needing to actually change the config.

@kurkle kurkle requested a review from etimberg November 15, 2019 07:58
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure I understand the concept of migrating wrapper, but do agree that some sort of migration helper would be useful

@etimberg etimberg merged commit 7f97adf into chartjs:master Nov 15, 2019
@kurkle kurkle deleted the level-up branch November 15, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider making scale.ticks only representative of the tick labels.

3 participants