Fix value passed to getPixelForTick #6724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
rm-ticksToDraw
branch
2 times, most recently
from
5ee0234 to
675a031
Compare
Member
|
|
Contributor
Author
|
It still does, but it's calculated before autoSkipping happens, and I'm not sure how to test what amount of |
benmccann
force-pushed
the
rm-ticksToDraw
branch
from
675a031 to
a82ef8a
Compare
kurkle
approved these changes
Nov 14, 2019
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Amount of offset added might change, but lets deal with that later if it becomes an issue.
etimberg
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6715
This improves memory usage by not keeping around an old copy of the ticks from before
autoSkipis run and also improves performance because when we iterate over all ticks that's now a much smaller set