-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for floating bar chart ([start, end]) #6056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is very close. There are two failing tests still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things to consider, I'm not saying they should be done though 😄
@gwyneblaidd #6077 which implements the option not to skip borders has been merged now, so you shouldn't need any changes to I normally don't recommend squashing commits, but I find that if you have many commits then squashing them first makes rebasing easier, so you may want to consider in this case ( |
d6758f1
to
c9f6167
Compare
_autoSkipp rolled back minbarlength. float-bar start fix start fix fix fix fixes fix fix fix fixes unittests comment removed reverse of borderSkipped
9f1079f
to
762dd88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, shouldn't we add docs in this PR?
Rebased float-bar support
Original PR: #5262