Skip to content

Conversation

@benmccann
Copy link
Contributor

No description provided.

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint seems to evolve rapidly. How about ^5.0.0?

@benmccann
Copy link
Contributor Author

I want to avoid getting the latest version of eslint because Chart.js is broken with it. If you run rm -rf node_modules package-lock.json then npm install and gulp lint it will fail. The latest commits on master are broken and this is an attempt to get our build back into a working state. We should figure out what the eslint or gulp-eslint issue is and fix it, but in the meantime I'd like to make sure Chart.js still works for everyone

@simonbrunel
Copy link
Member

Related to BenoitZugmeyer/eslint-plugin-html#113 and certainly fixed by BenoitZugmeyer/eslint-plugin-html#112

@benmccann
Copy link
Contributor Author

Ok. Closing this since the latest version is a working version. #6040 will need to be merged to fix the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants