(Rebase) Move drawing of gridLines into separate plugin and add border functionality #5480
Conversation
okcoker
changed the title
| glColor: lineColor, | ||
| glBorderDash: borderDash, | ||
| glBorderDashOffset: borderDashOffset, | ||
| tmWidth: lineWidth, |
There was a problem hiding this comment.
It took me awhile to figure out, but I'm guessing tm stands for tick mark. I would just use tick instead since it's not much longer and is much clearer
| var MODEL_KEY = '$gridlines'; | ||
|
|
||
| // This is copied from core.scale.js, which is also required here and im not sure where it should be placed for both of them to access it | ||
| function getLineValue(scale, index, offsetGridLines) { |
There was a problem hiding this comment.
I think this is now called getPixelForGridLine. The code no longer quite matches. I'd recommend making it an attribute of a class and marking it private by prefixing it with _ and adding a @private jsdoc tag so that it can be reused rather than copied here
|
This PR has been inactive for quite awhile and border functionality was added in #6883 so I'm going to close this. If you'd still like to get some of the additional changes from this PR in, we'd be happy to review them, but please join the #dev Slack channel to propose the changes ahead of time so that we can give early feedback to help make the process as painless as possible |
3 participants
Rebase fixes for #4117
JSFiddle: https://jsfiddle.net/y0whvnvk/78/