Fix for issue #4897: non adjacent stacked group is not rendered correctly #4906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Nov 1, 2017
src/controllers/controller.bar.js
Outdated
| * @private | ||
| */ | ||
| getStackCount: function(last) { | ||
| getStack: function(last) { |
Contributor
There was a problem hiding this comment.
should this be called getStacks since it looks like it can return multiple
Contributor
Author
|
I somehow closed this PR adding the proposed changes to the code. Opened a new PR #4911 |
Contributor
|
Just fyi, It's possible to re-open a closed PR |
Contributor
Author
|
The button is disabled. Is it also possible to add the review changes to a PR? |
Contributor
|
Yes, you can commit the changes on the same branch and push them in order to update a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #4897: stacked group is not rendered correctly when stack group is not adjacent.
Problem
Only the dataset index was used for indexing the stack.