Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update font spec type #11605

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Update font spec type #11605

merged 1 commit into from
Dec 4, 2023

Conversation

LeeLenaleee
Copy link
Collaborator

Resolves: #11603

Not sure if we see this as breaking 🤔

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Dec 4, 2023
@LeeLenaleee LeeLenaleee added this to the Version 4.4.1 milestone Dec 4, 2023
etimberg
etimberg approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it might break things, but also its a bug fix

@LeeLenaleee
Copy link
Collaborator Author

Yeah thought the same, worst case we revert it and wait for next major

@LeeLenaleee LeeLenaleee merged commit 8e19199 into chartjs:master Dec 4, 2023
8 checks passed
@LeeLenaleee LeeLenaleee deleted the update-font-spec-typing branch December 4, 2023 18:56
@crnkovic crnkovic mentioned this pull request Dec 12, 2023
Merged
@whitelisab whitelisab mentioned this pull request Dec 19, 2023
Merged
@raymondhtet raymondhtet mentioned this pull request May 29, 2024
Closed
@alfonsserra alfonsserra mentioned this pull request Jun 7, 2024
Closed
@brmzkw brmzkw mentioned this pull request Jun 7, 2024
Open
@DallinAllred DallinAllred mentioned this pull request Jun 22, 2024
Merged
@wanissr wanissr mentioned this pull request Jun 22, 2024
Open
@bwilliford bwilliford mentioned this pull request Jun 26, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Jul 5, 2024
Closed
@raymondhtet raymondhtet mentioned this pull request Jul 14, 2024
Closed
@faragashraf faragashraf mentioned this pull request Jul 18, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Aug 16, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 7, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Sep 8, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 12, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 16, 2024
Open
@karencapiiro karencapiiro mentioned this pull request Sep 17, 2024
Open
@scottwad scottwad mentioned this pull request Sep 24, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 24, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Sep 25, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Oct 1, 2024
Open
@nerds-github nerds-github mentioned this pull request Oct 27, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug type: types Typescript type changes
Projects
None yet
Milestone
Version 4.4.1
Development

Successfully merging this pull request may close these issues.

Type error with font weight as a number
2 participants
@LeeLenaleee @etimberg