-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rewrite config helpers to ts #11121
refactor: rewrite config helpers to ts #11121
Conversation
@dangreen looks like some conflicts to resolve before this can be merged |
@stockiNail I can go either way depending on when this gets rebased. I don't want this PR to have get rebased many times since that's a lot of work |
Could you rebase master into this so the CI works again? |
Test seem to be failing |
@LeeLenaleee I've got randomly failing tests that are passing successfully locally. |
@LeeLenaleee @dangreen I think the issue is related to FF 110. I have the same issue in If you see the history of the CI, you can see that the last one which ended correctly (testing the cases) was using FF 109. Starting using 110, the fixture test cases are failing randomly. And as @dangreen reported, locally it works correctly. |
FYI, I had a look to new feature of FF 110: https://www.mozilla.org/en-US/firefox/110.0/releasenotes/ Therefore in the test PR in annotation plugin, I have tried to disable it (not sure if the property is the correct one, :() with the following Karma config: customLaunchers: {
chrome: {
base: 'Chrome',
flags: [
'--disable-accelerated-2d-canvas',
'--disable-background-timer-throttling',
'--disable-backgrounding-occluded-windows',
'--disable-renderer-backgrounding'
]
},
firefox: {
base: 'Firefox',
prefs: {
'layers.acceleration.disabled': true,
'gfx.canvas.accelerated': false // <--- added this one!!! --->
}
}
}, and CI in the plugin ended correctly. EDIT: I have submitted a PR chartjs/chartjs-plugin-annotation#857 in EDIT 2: merged in the master of plugin and sounds working. Just 1 side effect that I have seen: sometimes the test could fail due to the timeout. Re-running it, usually ends correctly. |
Submitted PR to fix FF 110 acceleration: #11165 |
No description provided.