refactor: move to esm in sources #10879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the changes are for tsc to find the files? It seems developers are working for the tools and not the other way around, which is 💩 /rant |
kurkle
approved these changes
Nov 17, 2022
|
@kurkle Sooner or later, it would still have to be done cause ESM is the new standard. And I don't know why, but it also fixes the problem I met. |
LeeLenaleee
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to native ESM in sources with
"moduleResolution": "NodeNext".Also, it fixes the problem that I met here: https://github.com/reactchartjs/react-chartjs-2/pull/1109/files
For some reason, bundled types work differently with
"moduleResolution": "Node"and"moduleResolution": "NodeNext".