Skip to content

Conversation

@lucianosantana
Copy link
Contributor

Allows a typescript project to consume UpdateModeEnum.

It is basically the same fix from #9046 applied to a different enum.

I'd consider this as an extended fix for #8993

@etimberg etimberg added the type: types Typescript type changes label Sep 30, 2022
@etimberg etimberg added this to the Version 4.0 milestone Sep 30, 2022
@etimberg etimberg merged commit 6f4b365 into chartjs:master Sep 30, 2022
@etimberg
Copy link
Member

etimberg commented Sep 30, 2022

@kurkle I think we need to revert or fix this. It seems to be causing errors in #10728

@kurkle
Copy link
Member

kurkle commented Oct 1, 2022

How could it be fixed? Reverting is ok by me.

@etimberg
Copy link
Member

etimberg commented Oct 1, 2022

Got it fixed in #10729. It needs to be export declare const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: types Typescript type changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants