Object methods to access to chart.options as proxy

[stockiNail]

After the PR which changes the chart.options to a proxy, the usage of Object methods (like getOwnPropertyDescriptor or hasOwnProperty) are reporting only if the property are stored on top level.

Before the PR, the options, being built by merging the other options, the Object methods worked well.

I don't know if there is any possibility in order that proxy handler could work as before using the above methods, therefore going in cascade on the objects of different scopes.

[kurkle]

currently, Object.getOwnPropertyNames can be used to get all the available names. Can you describe the use case?

[stockiNail]

I'm using JSINTEROP and I have a java class which can wrap JS Object class and I'm using the standard methods of JS Object to manage properties because I can not use the normal javascript syntax.

To define properties, I'm using Object.defineProperty().
To check if a property exists, I'm using Object.prototype.hasOwnProperty().
To get the value of a property, I'm using Object.getOwnPropertyDescriptor().

I know that's a special case. But I was thinking that proxy implementation for chart.options (and only for options where before you have a merged object) could have specific method implementation of handler in order to do not stop the resource of scope but to go in cascade.

[kurkle]

I guess you can't use the in operator either.

Do you use any javascript side helpers with the JSINTEROP? You could create a javascript helpers for interacting with the options.

For example:

function setOptionValue(target, name, value) {
  target[name] = value;
}

function getOptionValue(target, name) {
    return target[name];
}

function hasOption(target, name) {
  return name in target;
}

(I'm not sure if this is something you can do though :D)

[stockiNail]

@kurkle Yes, I can! I am already using the in operator for the scriptable context.

And I can also use those functions as you describe, by the java script helper that I have already done where I have all things that JSInterop is not able to do !! :)

Also the instanceof could be helpful for me because I have a use case and I was getting crazy because the instanceof doesn't work with proxies (without prototype).

THANK YOU! Looking forward to test it.

[stockiNail]

@kurkle FYI I'm testing using Reflect and sounds work well with the proxy. Let me do some additional tests and I'm gonna give a feedback about my implementation, if ok for you.

[kurkle]

Did you have the time to test this already?

[stockiNail]

Did you have the time to test this already?

I wanted to write you and you arrived before me.

I'm following your suggestion with a js object wrapped in JSINTEROP.

Yes, I'm still testing (now as well) but I'm fighting because they are some conditions (that I'm not able to reproduce) where key in obj returning false even if the property exist in the object.
I have tried also Reflect.has but with the same result.

I'm testing the scale and set of min/max at runtime.
If not an problem, can you leave it, because I want to understand what is wrong.

[stockiNail]

Just for sharing. The following is the code that I did, a method to get if a property exists in a object/proxy:

function has(obj, key) {
    // debug fr a specific key 
    if (key  === 'max') {
       	console.log(key in obj); // returns false
       	console.log(Reflect.has(obj, key)); // returns false
       	console.log(obj[key] != undefined); // returns true
     } 
     return key in obj;
}

Here the proxy in the console:

[kurkle]

If you change the order, move logging of obj[key] first, do all the others return true too?

[stockiNail]

Tested right now, nothing changed.

function has(obj, key) {
    // debug fr a specific key 
    if (key  === 'max') {
       	console.log(obj[key] != undefined); // returns true
       	console.log(key in obj); // returns false
       	console.log(Reflect.has(obj, key)); // returns false
     } 
     return key in obj;
}

[stockiNail]

@kurkle I have another problem deleting a property.

https://stackoverflow.com/questions/40655553/how-to-delete-a-property-of-the-object-created-by-proxy

I want to ask you if could make sense to you to add deleteProperty in Proxy handler:

  deleteProperty(target, propKey) {
    return Reflect.deleteProperty(target, propKey);
  },

in order to remove a property and then the next get can perform the fallback.