Modernize build system to use pyproject.toml and build wheels#267
Merged
Modernize build system to use pyproject.toml and build wheels#267
Conversation
mayantaylor
force-pushed
the
maya/modernize-build
branch
from
10cbc46 to
1fd4889
Compare
mayantaylor
force-pushed
the
maya/modernize-build
branch
from
d1aa3a0 to
3a5a413
Compare
manually specifying package dir formatting typo manual cibuildwheel command? one dir down? adding debug info typo testing git installation clean up print statements typos removing 'build' dependency separating workflows adding testpypi workflow
mayantaylor
force-pushed
the
maya/modernize-build
branch
from
5aeff4b to
24a546c
Compare
ritvikrao
previously approved these changes
Aug 28, 2024
Collaborator
|
@matthiasdiener can you look at this as well? I think everything works here, but I wanted you to look over this as well |
Collaborator
Author
|
I'll be opening another PR to add tests to the binary distribution, unless it makes more sense to add that here. |
.github/workflows/build_wheels.yml
Outdated
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: charmplusplus/charm | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
Contributor
There was a problem hiding this comment.
Do we need the token here?
Collaborator
Author
There was a problem hiding this comment.
Looks like we don't, I removed it
matthiasdiener
previously approved these changes
Aug 28, 2024
Contributor
matthiasdiener
left a comment
matthiasdiener
left a comment
There was a problem hiding this comment.
Besides my two minor comments, this looks good!
ritvikrao
dismissed stale reviews from matthiasdiener and themself
via
9b102c5
ritvikrao
approved these changes
Aug 28, 2024
This was referenced Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to (1) modernize the build system to use pyproject.toml with the existing setup.py structure (see python docs), and (2) set up Github Actions to build wheels automatically (using cibuildwheel) for distribution via Pypi.
Full instructions for creating and publishing wheels have been added to the wiki.