[lbMerge - 4] Create distinct LBDatabase and LBManager, remove batsyncer, various cleanups#2530
Conversation
rbuch
changed the title
rbuch
changed the title
rbuch
force-pushed
the
lbMerge-4
branch
3 times, most recently
from
b4362ec to
d5c57ef
Compare
matthiasdiener
changed the title
epmikida
reviewed
Oct 3, 2019
Contributor
epmikida
left a comment
epmikida
left a comment
There was a problem hiding this comment.
I probably still need to look at this a bit more, but I've left a bunch of comments to start
kavithachandrasekar
force-pushed
the
lbMerge-4
branch
from
08bb5b6 to
5628261
Compare
stwhite91
reviewed
Mar 20, 2020
stwhite91
reviewed
Mar 20, 2020
Change-Id: I0b722dbf1d1e20cced100095a47e9a81e4352b7c
When an element was deleted from the registry, the nextEmpty pointer was not cleared, which caused it to point to non-empty positions in some cases
The hardcoded calls to ResumeFromSync and rest of the infrastructure are not compatible with async pups, so reverted to the original design and modernized the implementation
This reverts commit be32627.
This is no longer needed because receivers now call their corresponding std::function rather than a hardcoded named function.
epmikida
previously approved these changes
Mar 27, 2020
stwhite91
reviewed
Mar 27, 2020
examples/charm++/zerocopy/entry_method_api/prereg/stencil3d/stencil3d.C
Outdated
Show resolved
Hide resolved
stwhite91
approved these changes
Mar 31, 2020
epmikida
approved these changes
Mar 31, 2020
stwhite91
pushed a commit
that referenced
this pull request
May 11, 2023
…cer, various cleanups (#2530) Restructure the load balancing infrastructure, creating a new LBManager that is responsible for coordination and external interaction and relegating the LBDatabase to mostly store data. Additionally, a new flooding mechanism is being added to LocalBarrier, which removes the need for the batsyncer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.