add clarifications for docker registry #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwmonroe
suggested changes
Feb 4, 2021
pages/k8s/docker-registry.md
Outdated
| registry will be checked first for any image requests, so it can be used | ||
| in addition to public registries. For more details of the mechanics of | ||
| the Docker Registry, see the | ||
| [upstream documentation at https://docs.docker.com/registry][upstream registry]. |
There was a problem hiding this comment.
Suggested change
| [upstream documentation at https://docs.docker.com/registry][upstream registry]. | |
| [upstream documentation at https://docs.docker.com/registry][upstream-registry]. |
There was a problem hiding this comment.
do'h. the tests should have caught that
There was a problem hiding this comment.
So, unless you don't trust me, it is okay to point out things which need to be changed and approve it
|
@kwmonroe I'll leave you to imagine your own passive-aggressive comment here while I merge this, following your verbal approval and acknowledgement that it is great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533