fix(file): use height parameter as max height

[davidferneding]

While adding the padding parameter to file, the component has been refactored to use m.filepicker.SetHeight instead of the deprecated property m.filepicker.Height. Since this change, the size has been calculated based on the window height, overriding the value passed with --height.

This adds a new maxHeight property to constrain the maximum height of the file picker to the value passed by --height. The current behaviour of constraining the height to the window height has been preserved.

Refs: 6045525

Fixes #969

[tree-1917]

Hello @davidferneding, I try your solution to solve the bug in height calculation but I found it's change the behavior for the file command and can simply solve this problem by change the equation height := msg.Height - m.padding[0] - m.padding[2] - 1 it's works and you can see the screenshots before and after .

Before Bug

After No Bug

[davidferneding]

Sorry @tree-1917, I totally forgot to reply.

The changes in 6045525 changed two things for the file command. One change is, that the topmost option is being cut off. This can be fixed with the change you mentioned.

The other change is, that the file command no longer respects the --height parameter, using the whole window size instead. This behaviour has been mentioned in this comment: #977 (comment)

Before v0.17.0, the file command only used a couple of lines:

In v0.17.0, the command clears the screen and uses all available space. This pr fixes the height behaviour.