Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mangled newlines in definition lists #239

Closed
afranke opened this issue Jun 18, 2023 · 2 comments · Fixed by #317
Closed

Mangled newlines in definition lists #239

afranke opened this issue Jun 18, 2023 · 2 comments · Fixed by #317
Assignees
@caarlos0
Labels
bug Something isn't working

Comments

@afranke
Copy link

afranke commented Jun 18, 2023

Newlines get mangled after the first item in the list and everything until the end of the list gets shown as definitions for the first term.

First term
: Definition one of first term.

Second term
: Definition one of second term.

yields

  First term
  🠶 Definition one of first term.Second term
  🠶 Definition one of second term.

Adding more newlines between items doesn’t help.
@bashbunni
Copy link
Member

Thanks for reporting, just added to our list 👍

@hugginsio hugginsio mentioned this issue Jul 27, 2023
Open
@bugabinga
Copy link

A workaround, that should not cause too many issues with other parsers can be to separate the def list items by an escape char \.

First term
: Definition one of first term.
\
Second term
: Definition one of second term.

@caarlos0 caarlos0 self-assigned this Jul 16, 2024
caarlos0 added a commit that referenced this issue Jul 16, 2024
@caarlos0
fix: #239
b6567c6
@caarlos0 caarlos0 added the bug Something isn't working label Jul 16, 2024
@caarlos0 caarlos0 mentioned this issue Jul 16, 2024
Merged
bashbunni added a commit that referenced this issue Jul 31, 2024
@caarlos0 @bashbunni
fix: many rendering issues (#317)
5f5965e 
* wip

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* wip

* wip

* wip

* fix: autolink

closes #290

* fix: escape characters

closes #106
closes #274
closes #311

* fix: table

* ci: golangci lint update

* feat: use x/golden

* test: #106

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #290

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #312

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #257

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #149

* fix: #239

* feat: use lipgloss table

closes #262

Co-authored-by: bashbunni <bunni@bashbunni.dev>

* fix: codespan is not a block

* test: #315

* test: #316

* fix: #316

* test: table

* fix: codespans, tables

* test: table

* test: #117

* test: #60

* fix: rm stylewriter

* fix: #313

* fix: margin

* fix: blocks and word wrap

* fix: build

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* chore: gitattributes

* fix: test opt

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: stable lipgloss

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: double styles

* fix: tables

* fix: tables

---------

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: bashbunni <bunni@bashbunni.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: many rendering issues charmbracelet/glamour
4 participants
@afranke @caarlos0 @bugabinga @bashbunni