fix(anthropic): ToolChoiceNone should send tool_choice:{type:"none"} to API - #178
Merged
Merged
Conversation
…to API The Anthropic provider's toTools function was returning nil for anthropicToolChoice when ToolChoiceNone was set, which meant tool_choice was never included in the API request. The API defaults to "auto", so the model could still make tool calls. Now properly constructs ToolChoiceUnionParam with OfNone set using anthropic.NewToolChoiceNoneParam(). Also adds test coverage for ToolChoiceNone. * Closes #177 💘 Generated with Crush Assisted-by: Kimi K2.5 via Crush <crush@charm.land>
taigrr
pushed a commit
to taigrr/fantasy
that referenced
this pull request
Apr 20, 2026
…to API (charmbracelet#178) The Anthropic provider's toTools function was returning nil for anthropicToolChoice when ToolChoiceNone was set, which meant tool_choice was never included in the API request. The API defaults to "auto", so the model could still make tool calls. Now properly constructs ToolChoiceUnionParam with OfNone set using anthropic.NewToolChoiceNoneParam(). Also adds test coverage for ToolChoiceNone. * Closes charmbracelet#177 💘 Generated with Crush Assisted-by: Kimi K2.5 via Crush <crush@charm.land>
taigrr
pushed a commit
to taigrr/fantasy
that referenced
this pull request
Apr 25, 2026
…to API (charmbracelet#178) The Anthropic provider's toTools function was returning nil for anthropicToolChoice when ToolChoiceNone was set, which meant tool_choice was never included in the API request. The API defaults to "auto", so the model could still make tool calls. Now properly constructs ToolChoiceUnionParam with OfNone set using anthropic.NewToolChoiceNoneParam(). Also adds test coverage for ToolChoiceNone. * Closes charmbracelet#177 💘 Generated with Crush Assisted-by: Kimi K2.5 via Crush <crush@charm.land>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Anthropic provider's toTools function was returning nil for anthropicToolChoice when ToolChoiceNone was set, which meant tool_choice was never included in the API request. The API defaults to "auto", so the model could still make tool calls.
Now properly constructs ToolChoiceUnionParam with OfNone set using anthropic.NewToolChoiceNoneParam().
Also adds test coverage for ToolChoiceNone.
💘 Generated with Crush
Assisted-by: Kimi K2.5 via Crush crush@charm.land