feature: add ollama provider based partially on json output generated…#24
Open
zloeber wants to merge 5 commits intocharmbracelet:mainfrom
Open
feature: add ollama provider based partially on json output generated…#24zloeber wants to merge 5 commits intocharmbracelet:mainfrom
zloeber wants to merge 5 commits intocharmbracelet:mainfrom
Conversation
Author
|
Updated to only include models with the tools tag |
caarlos0
reviewed
Aug 15, 2025
| //go:embed configs/lambda.json | ||
| var lambdaConfig []byte | ||
|
|
||
| var ollamaConfig []byte |
caarlos0
requested changes
Aug 15, 2025
Member
caarlos0
left a comment
caarlos0
left a comment
There was a problem hiding this comment.
missing go embed, this will not work as is
kujtimiihoxha
requested review from
aymanbagabas and
kujtimiihoxha
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ollama provider based partially on the json data found in https://ollama-models.zwz.workers.dev/
Describe your changes
Ollama's library is really quite lacking in model information. This PR Adds each of the ollama catalog entries with max token and context window length data derived from the library readme data and online sources. Attachment support attribute is based on the readme data (looking for terms like 'vision') and may not be fully accurate. Reasoning model attributes are derived from both the readme data (terms such as 'reasoning') and online sources.
Related issue/discussion: link
Checklist before requesting a review
CONTRIBUTING.mdIf this is a feature