-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a cmd to request window size #988
Conversation
Co-authored-by: Christian Rocha <christian@rocha.is>
Because the PR got merged only a few hours ago and this issue is 100% certain linked to this PR, I'm writing no new issue but comment on this PR. Sorry for waiting until after the merge before testing this. In my test, when I send a I'm not too familiar with the codebase but searching for other occurrences of I hope I didn't formulate this too complicated otherwise feel free to ask me what I actually mean. Any thoughts on this? Also, didn't someone else had this issue as well? |
We need to run checkResize in a goroutine, otherwise, it will block. Related: #988 (comment) Fixes: 7d70838 (feat: add a cmd to request window size (#988))
@atticus-sullivan Thank you for noticing this one! I've opened #1059 to fix this one and add an example to request window size. |
Alright, thanks for the fast reply + fix. Also having an example for this is quite nice 👍 |
We need to run checkResize in a goroutine, otherwise, it will block. Related: #988 (comment) Fixes: 7d70838 (feat: add a cmd to request window size (#988))
Fixes: #987 (comment)