Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to suspend bubbletea programs #1054

Merged
merged 8 commits into from
Jul 11, 2024
Merged

feat: allow to suspend bubbletea programs #1054

merged 8 commits into from
Jul 11, 2024

Conversation

caarlos0
Copy link
Member

closes #497
closes #1053

based on @knz's implementation. thanks ❤️

@caarlos0 caarlos0 added the enhancement New feature or request label Jul 11, 2024
@knz
Copy link
Contributor

knz commented Jul 11, 2024

Thank you!

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in docstring

tea.go Outdated Show resolved Hide resolved
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
Copy link
Member Author

I also added a ResumeMsg programs can listen to, as the user might want to do something when the program is resumed 🙏🏻

@caarlos0
Copy link
Member Author

also made the program block and wait for a SIGCONT after sending SIGTSTP ⏲️

Copy link
Member

@meowgorithm meowgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so good. @knz, thanks for sharing your solve for this!

@caarlos0 caarlos0 merged commit ea13ffb into master Jul 11, 2024
18 checks passed
@caarlos0 caarlos0 deleted the suspend branch July 11, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspend/Resume bug: cannot suspend bubbletea process
3 participants