fix: split line based on width of viewport #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added iteration through each line to split the line to fit within viewport width
|
@meowgorithm PS It's my first open source PR so not sure if there's any standards/guidelines I missed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix content rendering in viewport by splitting each line based on viewport width.
Previous implementation had a bug where lines exceeding the width would show in the viewport on multiple lines but the number of lines
len(m.lines)would not reflect that. This results in the viewport rendering less lines than intended since line count is purely based on\nregardless of how many lines the content actually occupies on the terminal.