-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(viewport): auto-wrap #578
Open
kyu08
wants to merge
11
commits into
charmbracelet:master
Choose a base branch
from
kyu08:fix-height-calc-method
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
361dc3e
fix(viewport): fix height calculation method
kyu08 ee20954
fixup! fix(viewport): fix height calculation method
kyu08 eaff7e7
fix the panic caused by incorrect usage of lines
kyu08 5e1cef4
fix ScrollPercent
kyu08 8d78f89
rename the function and variables
kyu08 eb7b9d5
fix: use actual lines in `SetContent`
kyu08 6f9f512
fix: the test function's name
kyu08 a3e0450
refactor(viewport): clarify naming for wrapped lines
bashbunni ac3e89b
refactor(test): wrap words when possible
bashbunni 6ba0f57
fix(viewport): do not allow YOffset to exceed its max
bashbunni d815986
fix(viewport): remove `strings.TrimSpace`
kyu08 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package viewport | ||
|
||
import ( | ||
"testing" | ||
) | ||
|
||
func TestWrap(t *testing.T) { | ||
t.Parallel() | ||
tests := map[string]struct { | ||
lines []string | ||
width int | ||
want []string | ||
}{ | ||
"empty slice": { | ||
lines: []string{}, | ||
width: 3, | ||
want: []string{}, | ||
}, | ||
"all lines are within width": { | ||
lines: []string{"aaa", "bbb", "ccc"}, | ||
width: 3, | ||
want: []string{"aaa", "bbb", "ccc"}, | ||
}, | ||
"some lines exceeds width": { | ||
lines: []string{"aaaaaa", "bbbbbbbb", "ccc"}, | ||
width: 3, | ||
want: []string{"aaa", "aaa", "bbb", "bbb", "bb", "ccc"}, | ||
}, | ||
"full sentence exceeding width": { | ||
lines: []string{"hello bob, I like yogurt in the mornings."}, | ||
width: 12, | ||
want: []string{"hello bob, I", "like yogurt", "in the", "mornings."}, | ||
}, | ||
} | ||
|
||
for name, tt := range tests { | ||
t.Run(name, func(t *testing.T) { | ||
got := wrap(tt.lines, tt.width) | ||
|
||
if len(got) != len(tt.want) { | ||
t.Fatalf("expected len is %d but got %d", len(tt.want), len(got)) | ||
} | ||
for i := range tt.want { | ||
if tt.want[i] != got[i] { | ||
t.Fatalf("expected %s but got %s", tt.want[i], got[i]) | ||
} | ||
} | ||
}) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes that the width of the viewport is tied to the window width, which will not always be the case: viewports can have a fixed size. Additionally, this requires the user to flow
tea.WindowSizeMsgs
through a viewport's update. It would be better to simply re-wrap when the width of the viewport changes.In order to achieve this we'll probably need to deprecate
Width
and introduceSetWidth()
and a less-than-idealGetWidth()
. Inv2
we can correct the naming.