Skip to content

Conversation

coderdiaz
Copy link
Contributor

@coderdiaz coderdiaz commented Jun 22, 2016

Thank you for your efforts to make this component.

I've added a property to the text field with the purpose to obtain information within a form, as it did not have the property.

Also, I've added a translation feature.

You can accept the request or not, no problem =).
Best regards.

@coderdiaz coderdiaz changed the title Added name prop to input attribute Added name to input attribute by props Jun 22, 2016
coderdiaz and others added 2 commits June 23, 2016 13:27
Documentation to translation feature.
@coderdiaz coderdiaz changed the title Added name to input attribute by props Added name to input attribute and translations Jun 23, 2016
@charliekassel
Copy link
Owner

Hey @coderdiaz thank you for your contributions!
I'm currently away for a couple of weeks but will review when I return.

@coderdiaz
Copy link
Contributor Author

@charliekassel It's ok. Greetings.

let monthName = this.getMonthName(date.getMonth(), traslation.months.original)
let str = format
.replace(/S/, this.getNthSuffix(date.getDate()))
.replace(/D/, this.getDayNameAbbr(date, traslation.days))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suffix and day name rules were originally set to run last so as to not be overridden, for instance a suffix added to the third of the month would result in 3rd and would then get the d replaced by the day rule.
Was there another reason you moved these to the top?

Copy link
Contributor Author

@coderdiaz coderdiaz Jul 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the problem is this.
If you pick September or December in datepicker and the format is 'd MMMM yyyy', your return is for example '8 theptember 2016', the suffix /S/ overwrites 'S'eptember to 'Th'eptember.

And, with December is overwrites by the suffix /D/ to show the name day.

errordatepicker

It's therefore, I changed the elements initially to overwrites those rules first and then the others.

@charliekassel
Copy link
Owner

Great, thanks.
And thank you for your contributions!

@coderdiaz
Copy link
Contributor Author

coderdiaz commented Jul 16, 2016

Changes are ready!

@charliekassel charliekassel merged commit 5073efc into charliekassel:master Jul 18, 2016
charliekassel pushed a commit that referenced this pull request Nov 3, 2016
charliekassel pushed a commit that referenced this pull request Sep 22, 2017
charliekassel pushed a commit that referenced this pull request Dec 24, 2017
Switch month and year depending on the selected language
charliekassel pushed a commit that referenced this pull request Apr 27, 2018
mkopinsky pushed a commit to mkopinsky/vuejs-datepicker that referenced this pull request Jun 17, 2019
…CalendarOnFocus

add showCalendarOnFocus prop
milankyncl referenced this pull request in milankyncl/vuejs-datepicker Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants