Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds a simple debian package on tag #386

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds macOS-13
  • Loading branch information
svavassori committed Jun 27, 2023
commit a08bc582a632eaba83141c2a5cab18941a8c1d54
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
build:
strategy:
matrix:
os: [ ubuntu-22.04, macos-latest, rpi3b, macos-11, macos-12, ubuntu-latest, ubuntu-20.04 ]
os: [ ubuntu-22.04, macos-latest, rpi3b, macos-11, macos-12, macos-13, ubuntu-latest, ubuntu-20.04 ]
runs-on: ${{ matrix.os }}
timeout-minutes: 35 # runtime across all OSs, runs can get queued and mac runs take 15-20 min
steps:
Expand Down
1 change: 1 addition & 0 deletions script/install_macos_dependencies.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ brew install \
soapysdr \
pulseaudio \
pkg-config
brew link openssl
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is openssl a new dependency? should it be included in the install list as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't a new dependency and it is installed by default; it is used by libshout3 if I remember correctly, so probably a hidden one.

On macOS 13 it doesn't have the link created by default, so the build fails because cannot find it (even if it's installed).
I don't know if it's a new default from macOS-13 or if it's a bug in the setup configuration of the worker VM