Cluster targeting #244
Cluster targeting #244
Conversation
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-bf74131 |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-9e8261e |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-6f5cf29 |
There was a problem hiding this comment.
Pull request overview
This PR implements cluster targeting functionality for VM deployments, allowing users to specify a cluster instead of a specific host. The system automatically selects the optimal host within the cluster based on available memory.
- Adds
target_clusterfield toManagedDeploymentRequestas an alternative totarget_host - Implements automatic host selection based on memory availability when deploying to a cluster
- Updates the UI to support both host-specific and cluster-based deployment modes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
server/app/core/pydantic_models.py |
Makes target_host optional, adds target_cluster field, and adds validation ensuring exactly one deployment target is specified |
server/app/api/routes.py |
Implements cluster-to-host resolution logic with memory-based host selection and auto-enables clustering for cluster deployments |
server/app/services/job_service.py |
Adds resolved_target_host parameter to handle both direct host and cluster-resolved host targeting |
next-ui/src/lib/components/modals/VmProvisionModal.svelte |
Adds deployment mode selector (host/cluster), fetches available clusters, and updates form to conditionally show host or cluster selection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-3949423 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Comments suppressed due to low confidence (1)
next-ui/src/lib/components/modals/VmProvisionModal.svelte:282
- The frontend UI collects
disk_typeandcontroller_typevalues from the user, but these fields are not included in the payload sent to the API. Looking at the backend code (job_service.py lines 1188-1189), these values are hardcoded to "Dynamic" and "SCSI" respectively. Either the ManagedDeploymentRequest model should be updated to include these fields so users can customize them, or the UI should remove these fields from the form to avoid misleading users into thinking their selections will be respected.
const payload: Record<string, any> = {
// Deployment target - either host or cluster
...(deploymentMode === "host"
? { target_host: targetHost }
: { target_cluster: targetCluster }),
// VM hardware
vm_name: vmData.vm_name,
gb_ram: vmData.gb_ram,
cpu_cores: vmData.cpu_cores,
storage_class: vmData.storage_class || undefined,
vm_clustered: vmData.vm_clustered,
// Disk - if image_name provided, disk will be created
image_name: imageName || undefined,
disk_size_gb: diskData.disk_size_gb,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-e310815 |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-bf8481c |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-c297ff9 |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-3a43f94 |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-87d67e2 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-83300eb |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-b1e2052 |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-ba2efa2 |
|
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-244
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-58d7c31 |
No description provided.