-
Notifications
You must be signed in to change notification settings - Fork 0
Extend inventory #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend inventory #238
Conversation
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-238
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-ff1df8a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR extends the VM and network adapter inventory collection to capture comprehensive Hyper-V configuration details, including security settings, boot configuration, host actions, integration services, and network adapter policies.
Key Changes
- Added 17 new VM properties including secure boot, TPM, boot device, host recovery/stop actions, dynamic memory buffer, cluster, and 6 integration service flags
- Added 6 new network adapter properties including MAC address configuration, security guards (DHCP/router/spoof), and bandwidth limits
- Implemented corresponding PowerShell data collection via CIM queries and Python deserialization with type coercion
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/app/services/inventory_service.py | Added deserialization for 17 new VM fields and 6 new network adapter fields; implemented _coerce_host_recovery_action and _coerce_host_stop_action helper methods to map string values to enums |
| Powershell/Inventory.Collect.ps1 | Extended CIM queries to collect VM security settings (TPM, secure boot), boot configuration, host actions, integration services status, and network adapter security/bandwidth settings; added helper function Get-IntegrationState and mapping logic for recovery/stop actions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-238
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-4eb3448 |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-238
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-a0c7a03 |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-238
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-8b69856 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-238
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-b9fea51 |
Container Build CompletedPublished Tags: Registry Info:
How to Test: # Pull the PR-specific image
docker pull ghcr.io/charlespick/aetherv-server:pr-238
# Or use the commit SHA
docker pull ghcr.io/charlespick/aetherv-server:sha-25daa80 |
No description provided.