Use vector cards instead of tuple cards #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like we lose about a microsecond per play on performance, but I don't think it's a big issue. Ultimately, this will help fix #228 in a less clunky way (if we were using Tuples). |
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 73.35% 73.54% +0.18%
==========================================
Files 17 17
Lines 1460 1478 +18
==========================================
+ Hits 1071 1087 +16
- Misses 389 391 +2
|
charleskawczynski
force-pushed
the
ck/vec
branch
from
ee26fcd
to
e2a0854
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Table and Players
cardsmember fromUnion{..., Tuple{Card,...}}toVector{Card}. The main reason this is useful is because we do mutate these cards during games (e.g., during deal), so it's a bit more ergonomic to have them be vectors than tuples.