Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add printing of ascii objects #227

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Add printing of ascii objects #227

merged 2 commits into from
Aug 31, 2023

Conversation

charleskawczynski
Copy link
Owner

Closes #198.

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Aug 30, 2023
@bors @charleskawczynski
Merge #227
77c2a9d 
227: Add printing of ascii objects r=charleskawczynski a=charleskawczynski

Closes #198.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2023

Build failed:

@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #227 (f18594c) into main (0dbc474) will decrease coverage by 5.84%.
Report is 3 commits behind head on main.
The diff coverage is 20.52%.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   79.19%   73.35%   -5.84%     
==========================================
  Files          14       17       +3     
  Lines        1336     1460     +124     
==========================================
+ Hits         1058     1071      +13     
- Misses        278      389     +111
Files Changed Coverage Δ
src/terminal/ascii_player.jl 0.00% <0.00%> (ø)
src/terminal/config_game.jl 0.00% <0.00%> (ø)
src/terminal/ascii_card.jl 3.22% <3.22%> (ø)
src/terminal/ui.jl 6.12% <6.12%> (ø)
src/table.jl 95.65% <16.66%> (-1.93%) ⬇️
src/transactions.jl 76.89% <27.27%> (-0.99%) ⬇️
src/terminal/human_player_options.jl 88.00% <52.63%> (-12.00%) ⬇️
src/player_type.jl 95.23% <66.66%> (-4.77%) ⬇️
src/game.jl 93.10% <76.92%> (-0.92%) ⬇️
src/TexasHoldem.jl 100.00% <100.00%> (ø)

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Aug 30, 2023
@bors @charleskawczynski
Merge #227
d690912 
227: Add printing of ascii objects r=charleskawczynski a=charleskawczynski

Closes #198.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2023

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 31, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f9e3fb4 into main Aug 31, 2023
17 of 19 checks passed
@bors bors bot deleted the ck/ascii branch August 31, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve terminal play experience
1 participant
@charleskawczynski