Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulling fix-paths into main #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pulling fix-paths into main #51

wants to merge 1 commit into from

Conversation

charcoal-butler[bot]
Copy link
Contributor

Merge fix-paths into main

Changes :

Bug Fixes

  • app: fix base path and public path for app and filesystem (2ce2b58)

@charcoal-butler charcoal-butler bot requested review from a team and mducharme and removed request for a team August 3, 2022 14:30
mcaskill
mcaskill reviewed Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@mcaskill mcaskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we are reverting back to relative paths and trailing slashes on directory paths?

@mcaskill mcaskill assigned mducharme and veve40 and unassigned mducharme Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcaskill mcaskill mcaskill left review comments

@mducharme mducharme Awaiting requested review from mducharme mducharme was automatically assigned from charcoalphp/reviewers

@JoelAlphonso JoelAlphonso Awaiting requested review from JoelAlphonso

@BeneRoch BeneRoch Awaiting requested review from BeneRoch

Assignees

@veve40 veve40

Labels
automatic-pr release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcaskill @mducharme @veve40